Fixed a bug where the state of the Remember Session checkbox was not used correctly

README

@@ -250,7 +250,8 @@ flexible when it comes to ordering the category and IdP entries.
 
 Changes:
 1.13   - Added Favourite IdPs to Embedded WAYF
-       - Fixed Remember Selection preference
+       - Fixed a bug where the state of the "Remember for session" checkbox was
+         not remembered.
 1.12.2 - Fixed a XSS security vulnerability
        - Fixed an error in function appendValueToIdPArray
          Thanks to Martins Purins from Latvijas Universitates for reporting this

templates.php

@@ -218,7 +218,7 @@ function printEmbeddedWAYFScript(){
 	$loggedInString =  getLocalString('logged_in');
 	$configurationScriptUrl = preg_replace('/embedded-wayf.js/', 'embedded-wayf.js/snippet.html', 'https://'.$_SERVER['SERVER_NAME'].$_SERVER['REQUEST_URI']);
 	$utcTime = time();
-	$checkedBool = (isset($_COOKIE[$redirectCookieName]) && !empty($_COOKIE[$redirectCookieName])) ? 'checked="checked"' : '' ;
+	$checkedBool = (isset($_COOKIE[$redirectStateCookieName]) && !empty($_COOKIE[$redirectStateCookieName])) ? 'checked="checked"' : '' ;
 	$rememberSelectionText = addslashes(getLocalString('remember_selection'));
 	$loginString = addslashes(getLocalString('login'));
 	$selectIdPString = addslashes(getLocalString('select_idp'));