Make a _copy_ of the attributes when copying them.

Doh! Closes RADSECPROXY-53.

Make a _copy_ of the attributes when copying them.
Doh! Closes RADSECPROXY-53.
26c8061a · Linus Nordberg · d413b14b · 26c8061a · 26c8061a
Commit 26c8061a authored Aug 28, 2013 by Linus Nordberg
Hide whitespace changes
Inline Side-by-side

Showing with 6 additions and 1 deletion

ChangeLog ChangeLog +5 -0

radmsg.c radmsg.c +1 -1

No files found.
--- a/ChangeLog
+++ b/ChangeLog
+Changes since 1.6.4
+	Bug fixes:
+	- Fix a crash bug introduced in 1.6.4. Fixes RADSECPROXY-53,
+	bugfix on 1.6.4.
+
 2013-09-05 1.6.4
 	Bug fixes:
 	- Keeping Proxy-State attributes in all replies to clients

--- a/radmsg.c
+++ b/radmsg.c
@@ -118,7 +118,7 @@ int radmsg_copy_attrs(struct radmsg *dst,
    int n = 0;

    for (node = list_first(list); node; node = list_next(node)) {
-        if (radmsg_add(dst, (struct tlv *) node->data) != 1) {
+        if (radmsg_add(dst, copytlv((struct tlv *) node->data)) != 1) {
            n = -n;
            break;
        }