Commit 16b7cc3b authored by Scott Cantor's avatar Scott Cantor
Browse files

Fix compiler warnings.

parent b94abd72
...@@ -112,12 +112,6 @@ namespace log4shib { ...@@ -112,12 +112,6 @@ namespace log4shib {
**/ **/
virtual void removeAllAppenders(); virtual void removeAllAppenders();
/**
* FixedContextAppenders cannot own Appenders.
* @returns false
**/
virtual bool ownsAppender() const throw();
/** /**
* FixedContextAppenders cannot own Appenders. * FixedContextAppenders cannot own Appenders.
* @returns false * @returns false
......
...@@ -128,7 +128,9 @@ namespace log4shib { ...@@ -128,7 +128,9 @@ namespace log4shib {
int _socket; int _socket;
in_addr_t _ipAddr; in_addr_t _ipAddr;
private: private:
#ifdef WIN32
int _cludge; int _cludge;
#endif
}; };
} }
......
...@@ -25,7 +25,7 @@ namespace log4shib { ...@@ -25,7 +25,7 @@ namespace log4shib {
// empty // empty
} }
void AbortAppender::_append(const LoggingEvent& event) { void AbortAppender::_append(const LoggingEvent&) {
std::abort(); std::abort();
} }
...@@ -37,7 +37,7 @@ namespace log4shib { ...@@ -37,7 +37,7 @@ namespace log4shib {
return false; return false;
} }
void AbortAppender::setLayout(Layout* layout) { void AbortAppender::setLayout(Layout*) {
return; return;
} }
} }
...@@ -44,11 +44,11 @@ namespace log4shib { ...@@ -44,11 +44,11 @@ namespace log4shib {
return result; return result;
} }
void FixedContextCategory::addAppender(Appender* appender) throw() { void FixedContextCategory::addAppender(Appender*) throw() {
// XXX do nothing for now // XXX do nothing for now
} }
void FixedContextCategory::addAppender(Appender& appender) { void FixedContextCategory::addAppender(Appender&) {
// XXX do nothing for now // XXX do nothing for now
} }
...@@ -68,12 +68,8 @@ namespace log4shib { ...@@ -68,12 +68,8 @@ namespace log4shib {
void FixedContextCategory::removeAllAppenders() { void FixedContextCategory::removeAllAppenders() {
// XXX do nothing for now // XXX do nothing for now
} }
bool FixedContextCategory::ownsAppender() const throw() {
return false;
}
bool FixedContextCategory::ownsAppender(Appender* appender) const throw() { bool FixedContextCategory::ownsAppender(Appender*) const throw() {
return false; return false;
} }
...@@ -82,7 +78,7 @@ namespace log4shib { ...@@ -82,7 +78,7 @@ namespace log4shib {
_delegate.callAppenders(event); _delegate.callAppenders(event);
} }
void FixedContextCategory::setAdditivity(bool additivity) { void FixedContextCategory::setAdditivity(bool) {
// XXX do nothing for now // XXX do nothing for now
} }
......
...@@ -113,7 +113,7 @@ namespace log4shib { ...@@ -113,7 +113,7 @@ namespace log4shib {
} }
} }
void NDC::_setMaxDepth(int maxDepth) { void NDC::_setMaxDepth(int) {
// XXX no maximum // XXX no maximum
} }
......
...@@ -55,7 +55,7 @@ namespace log4shib { ...@@ -55,7 +55,7 @@ namespace log4shib {
_literal(literal) { _literal(literal) {
} }
virtual void append(std::ostringstream& out, const LoggingEvent& event) { virtual void append(std::ostringstream& out, const LoggingEvent&) {
out << _literal; out << _literal;
} }
...@@ -123,7 +123,7 @@ namespace log4shib { ...@@ -123,7 +123,7 @@ namespace log4shib {
}; };
struct ProcessorTimeComponent : public PatternLayout::PatternComponent { struct ProcessorTimeComponent : public PatternLayout::PatternComponent {
virtual void append(std::ostringstream& out, const LoggingEvent& event) { virtual void append(std::ostringstream& out, const LoggingEvent&) {
out << ::clock(); out << ::clock();
} }
}; };
......
...@@ -97,7 +97,6 @@ namespace log4shib { ...@@ -97,7 +97,6 @@ namespace log4shib {
Properties::const_iterator to = _properties.lower_bound(prefix + '/'); Properties::const_iterator to = _properties.lower_bound(prefix + '/');
for(Properties::const_iterator i = from; i != to; ++i) { for(Properties::const_iterator i = from; i != to; ++i) {
const std::string& key = (*i).first; const std::string& key = (*i).first;
const std::string& value = (*i).second;
std::list<std::string> propNameParts; std::list<std::string> propNameParts;
std::back_insert_iterator<std::list<std::string> > pnpIt(propNameParts); std::back_insert_iterator<std::list<std::string> > pnpIt(propNameParts);
StringUtil::split(pnpIt, key, '.'); StringUtil::split(pnpIt, key, '.');
......
...@@ -66,8 +66,10 @@ namespace log4shib { ...@@ -66,8 +66,10 @@ namespace log4shib {
_facility((facility == -1) ? LOG_USER : facility), _facility((facility == -1) ? LOG_USER : facility),
_portNumber((portNumber == -1) ? 514 : portNumber), _portNumber((portNumber == -1) ? 514 : portNumber),
_socket (0), _socket (0),
_ipAddr (0), _ipAddr (0)
_cludge (0) #ifdef WIN32
,_cludge (0)
#endif
{ {
open(); open();
} }
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment